Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLDR-5854 First attempt with examples for two cases per item #3986

Conversation

haytenf
Copy link
Contributor

@haytenf haytenf commented Aug 27, 2024

CLDR-5854

Locale Before After
cy Screenshot 2024-08-27 at 4 33 56 PM Screenshot 2024-08-27 at 4 34 32 PM
cy Screenshot 2024-08-27 at 4 35 20 PM Screenshot 2024-08-27 at 4 50 53 PM
cy Screenshot 2024-08-27 at 4 36 47 PM Screenshot 2024-08-27 at 4 37 19 PM
cy Screenshot 2024-08-27 at 4 43 45 PM Screenshot 2024-08-27 at 4 46 19 PM
cy Screenshot 2024-08-27 at 4 53 20 PM Screenshot 2024-08-27 at 4 39 28 PM
ro Screenshot 2024-08-27 at 4 56 03 PM Screenshot 2024-08-27 at 4 57 18 PM
ro Screenshot 2024-08-27 at 4 56 21 PM Screenshot 2024-08-27 at 4 57 54 PM
ro Screenshot 2024-08-27 at 5 02 07 PM (future-few) Screenshot 2024-08-27 at 5 01 05 PM
ro Screenshot 2024-08-27 at 4 59 38 PM Screenshot 2024-08-27 at 5 03 43 PM
it Screenshot 2024-08-27 at 5 05 34 PM Screenshot 2024-08-27 at 5 06 23 PM
it Screenshot 2024-08-27 at 5 06 51 PM Screenshot 2024-08-27 at 5 07 40 PM
  • This PR completes the ticket.

ALLOW_MANY_COMMITS=true

@haytenf
Copy link
Contributor Author

haytenf commented Aug 27, 2024

@macchiati @srl295 This is just an initial attempt at the ticket based on my understanding. It doesn't fully cover the context/casing purpose (which might need to be split out into a separate ticket). If you take a look at the example screenshots in the markdown table (specifically the images for Romanian), there are two reasons I'm noticing why it won't cover the context/casing side:

  1. simple date format produces the date appropriately lowercased for Romanian, which is then formatted with the relative item, so the middle-of-sentence capitalization issue doesn't arise

  2. the pattern I use for some of the examples is MMMMd, and when formatted using the rules for Romanian d comes first, so the capitalization becomes irrelevant

In terms of just getting examples in for the relative items, it might still be a starting point. I still need to get a few more tests in and clean up the code but wanted to get feedback design wise.

@btangmu btangmu self-requested a review September 3, 2024 18:11
@haytenf haytenf marked this pull request as ready for review September 9, 2024 16:34
@haytenf
Copy link
Contributor Author

haytenf commented Sep 9, 2024

@macchiati @srl295 This is just an initial attempt at the ticket based on my understanding. It doesn't fully cover the context/casing purpose (which might need to be split out into a separate ticket). If you take a look at the example screenshots in the markdown table (specifically the images for Romanian), there are two reasons I'm noticing why it won't cover the context/casing side:

  1. simple date format produces the date appropriately lowercased for Romanian, which is then formatted with the relative item, so the middle-of-sentence capitalization issue doesn't arise
  2. the pattern I use for some of the examples is MMMMd, and when formatted using the rules for Romanian d comes first, so the capitalization becomes irrelevant

In terms of just getting examples in for the relative items, it might still be a starting point. I still need to get a few more tests in and clean up the code but wanted to get feedback design wise.

@btangmu @srl295 @macchiati Just wanted to follow up and see if anyone has any input about the new examples from this.

@haytenf haytenf closed this Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant